fix: install-egctl doc dead link #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Zhou <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2916 +/- ##
==========================================
- Coverage 64.62% 64.57% -0.05%
==========================================
Files 122 122
Lines 21115 21115
==========================================
- Hits 13645 13636 -9
- Misses 6624 6632 +8
- Partials 846 847 +1 ☔ View full report in Codecov by Sentry. |
shawnh2
reviewed
Mar 13, 2024
| @@ -52,6 +52,6 @@ curl -fsSL https://gateway.envoyproxy.io/get-egctl.sh | VERSION=latest bash | |||
|
|
|||
| {{% alert title="Next Steps" color="warning" %}} | |||
|
|
|||
| You can refer to [User Guides](/latest/user/egctl) to more details about egctl. | |||
There was a problem hiding this comment.
good catch! let's use /latest/user/operations/egctl instead, since this User Guides is about egctl
Signed-off-by: Dennis Zhou <[email protected]>
|
/retest |
arkodg
reviewed
Mar 13, 2024
arkodg
reviewed
Mar 13, 2024
arkodg
reviewed
Mar 13, 2024
|
we need to link to version specific pages, added some comments around that |
Signed-off-by: Dennis Zhou <[email protected]>
|
once agin, we really need preview -3- |
arkodg
approved these changes
Mar 14, 2024
zirain
approved these changes
Mar 15, 2024
arkodg
approved these changes
Mar 15, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes: